Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inhibition of MatchingNumberOfPrometheusAndCluster #481

Merged
merged 3 commits into from
Apr 9, 2021
Merged

Fix inhibition of MatchingNumberOfPrometheusAndCluster #481

merged 3 commits into from
Apr 9, 2021

Conversation

TheoBrigitte
Copy link
Member

Towards: giantswarm/giantswarm#15948

@TheoBrigitte TheoBrigitte self-assigned this Apr 1, 2021
@TheoBrigitte TheoBrigitte requested a review from a team April 1, 2021 16:14
@mig4
Copy link
Contributor

mig4 commented Apr 6, 2021 •
edited
Loading

Testing on gorgoth

before

Kill KSM: kubectl scale deployment -l app=kube-state-metrics --replicas=0

Inhibiting alert on Alert Manager:

1-before 2 am-inhibition-alert 2021-04-06--15-05-20

Inhibited alert on Alert Manager:

1-before 4 am-matchingprom-alert 2021-04-06--15-09-19

Alert in slack:

1-before 5 slack-matchingprom-alert 2021-04-06--15-10-47

so the cluster_id label doesn't match between them and so the inhibition doesn't kick in.

after

Inhibiting alert on Alert Manager:

2-after 2 am-inhibition-alert 2021-04-07--11-54-39

Inhibited alert on Alert Manager:

2-after 4 am-matchingprom-alert 2021-04-07--12-11-50

No alert in slack.

after (with inhibition only when MC KSM down)

This is with the commit that adds the constraint to source_match to only match KSM down inhibition coming from the Management Cluster (i.e. with cluster_id label set to the installation name) - https://github.com/giantswarm/g8s-prometheus/pull/1278/commits/73d884de8f12d5382305021fccdddbddaa644959

Inhibiting alert on Alert Manager:

3-after-mcksm 2 am-inhibition-alert 2021-04-07--13-56-11

Inhibited alert on Alert Manager:

3-after-mcksm 4 am-matchingprom-alert 2021-04-07--14-32-37

No alert in slack.

@mig4
Copy link
Contributor

mig4 commented Apr 7, 2021

Tested again after the cleanups, all good, still works OK. PTAL.

@mig4 mig4 changed the title use cancel_if_any_kube_state_metrics_down for MatchingNumberOfPrometheusAndCluster Fix inhibition of MatchingNumberOfPrometheusAndCluster Apr 9, 2021
@mig4 mig4 merged commit 24e0465 into master Apr 9, 2021
@mig4 mig4 deleted the cancel_if_any_kube_state_metrics_down branch April 9, 2021 12:26
mig4 added a commit that referenced this pull request Apr 9, 2021
@mig4
Fix changelog
e14f5c8 
Somehow the changelog entry from #481 ended up under previous release header.
@mig4 mig4 mentioned this pull request Apr 9, 2021
Merged
3 tasks
QuentinBisson pushed a commit that referenced this pull request Apr 9, 2021
@mig4
Fix changelog (#498)
353eddd 
Somehow the changelog entry from #481 ended up under previous release header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuentinBisson QuentinBisson QuentinBisson approved these changes

@JosephSalisbury JosephSalisbury JosephSalisbury approved these changes

Assignees

@TheoBrigitte TheoBrigitte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheoBrigitte @mig4 @JosephSalisbury @QuentinBisson